ruby on rails - How to DRY up this RSpec controller spec? -

-

how can dry spec up?

describe api::taskscontroller, type: :controller   'allows creator of task destroy it'     set_request_auth_header @user     delete :destroy, id: @task.id     expect(response).to be_success     expect(task.count).to eq 0   end    'does not allow assignee of task destroy it'     set_request_auth_header @assignee     delete :destroy, id: @task.id     expect(response).to be_forbidden     expect(task.count).to eq 1   end    'does not allow unrelated task destroy it'     set_request_auth_header @spy     delete :destroy, id: @task.id     expect(response).to be_forbidden     expect(task.count).to eq 1   end end

you extract methods:

describe api::taskscontroller, type: :controller   'allows creator of task destroy it'     expect_delete_to_succeed @user   end    'does not allow assignee of task destroy it'     expect_delete_to_be_forbidden @assignee   end    'does not allow unrelated task destroy it'     expect_delete_to_be_forbidden @spy   end    def expect_delete_to_succeed(requester)     delete_task requester     expect(response).to be_success     expect(task.count).to eq 0   end    def expect_delete_to_be_forbidden(requester)     delete_task requester     expect(response).to be_forbidden     expect(task.count).to eq 1   end    def delete_task(requester)     set_request_auth_header requester     delete :destroy, id: @task.id   end  end

side notes:

  • using instance (@) variables not current standard practice in rspec. let 'variables'.
  • task.exists? @task.id seems clearer way of checking deletion checking task.count.

Comments

Post a Comment

Popular posts from this blog

mysql - Dreamhost PyCharm Django Python 3 Launching a Site -

-
i'm new python/django , created simple django website using pycharm. site works fine running on computer, i'm lost when comes taking site onto host (dreamhost). i'm able upload files correct directories fine, , believe made correct changes database on mysql. i'm not sure go there though. right now, page shows files rather site. direction appreciated. much! you should not run django application using python manage.py runserver on production. how run application on django depends on server (apache, nginx) want use for apache - https://docs.djangoproject.com/en/1.10/howto/deployment/wsgi/modwsgi/ for nginx - https://www.digitalocean.com/community/tutorials/how-to-serve-django-applications-with-uwsgi-and-nginx-on-ubuntu-14-04 the mysql database should, of course, exist , have correct credentials. or, if choose use sqlite, file should accessible, readable , writable www-user (may different depending on linux distributive)
Read more

java - Sending SMS with SMSLib and Web Services -

-
i have made rest web service send smss using hsdpa usb modem. using smslib in java send smss. every time web service invoked, create gateway start service, send message, stop service , remove gateway. takes 20 seconds each message. found starting service takes lot of time. part of code use send smss service.getinstance().addgateway(gateway); service.getinstance().startservice(); outboundmessage msg = new outboundmessage(phonenumber, message); if (service.getinstance().sendmessage(msg)) { result = "message sent successfully!!"; } else { result = "could not send message."; } service.getinstance().stopservice(); service.getinstance().removegateway(gateway);//remove gateway is there way can start service once if not started , use send message when ever web service invoked? why dont group messages , send in 1 go? service.getinstance().sendmessages(messa...
Read more

php - What are the best practices for creatiang a "settings" model in Laravel 5? -

-
this first project using laravel (i'm starting 5.2). i'm building self managed website. there's admin should save site settings using later in website. eg: background color, social networks, carousel pictures, products, etc. my first try creating model "setting" with: id | key (unique) | value. when tried save social networks (to display in site header), realized i'd have save in "value" json url, title, etc... ugly implementation relational model, came conclussion bad. created sepparated model socialnetwork with: id | url | image | name. now i'm thinking in loading these models @ once in basecontroller can have through controllers, i'm not sure it's correct. mean, array $settings models part of it: abstract class basecontroller extends controller { protected $settings; ... public function __construct(...) { $this->settings = [ 'backgroundcolor' => 'red', ...
Read more